Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Neo.SmartContract.Framework according to last neo3 changes #106

Merged
merged 36 commits into from
Oct 24, 2019
Merged

Update Neo.SmartContract.Framework according to last neo3 changes #106

merged 36 commits into from
Oct 24, 2019

Conversation

shargon
Copy link
Member

@shargon shargon commented Sep 11, 2019 •
edited
Loading

This changes pretend update the syscalls according to the last changes for neo3. A lot of changes was done and the compiler was not updated

Require: neo-project/neo#1081 neo-project/neo-vm#215
Required for: #90

  • Added unit tests for all syscalls
  • A unit test was included for ensure that this will be updated acording to the last neo nuget

@shargon shargon mentioned this pull request Sep 11, 2019
Merged
This was referenced Sep 18, 2019
Merged
Closed
@shargon shargon marked this pull request as ready for review September 19, 2019 11:22
@shargon
Copy link
Member Author

shargon commented Sep 19, 2019

Waiting for neo-project/neo#1081

@shargon
Copy link
Member Author

shargon commented Oct 19, 2019 •
edited
Loading

@erikzhang The native contracts expose the Main method here

https://github.com/neo-project/neo/blob/4112df22fa5c5080dc0c39469e298db7fa4f85ef/neo/SmartContract/Native/NativeContract.cs#L88-L89

But at the same time, they don't allow direct calls and i try to understand why, because at the beginning i thought that the declaration of these syscalls should be like this.

https://github.com/neo-project/neo-devpack-dotnet/pull/106/files#diff-b88b415c97eb9e65791b85a3abc1e887R5-R12

@shargon shargon changed the title Update syscalls according to last neo3 changes Update Neo.SmartContract.Framework according to last neo3 changes Oct 19, 2019
This was referenced Oct 21, 2019
Merged
Closed
@shargon shargon mentioned this pull request Oct 22, 2019
Closed
@shargon
Copy link
Member Author

shargon commented Oct 23, 2019

Ready to review @neo-project/core

@shargon shargon merged commit 502c0ab into neo-project:master Oct 24, 2019
@shargon shargon deleted the more-syscalls branch October 24, 2019 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikzhang erikzhang erikzhang approved these changes

@vncoelho vncoelho Awaiting requested review from vncoelho

Assignees
No one assigned
Labels
blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shargon @erikzhang @vncoelho